move the wait to outer loop

WAN-3597 #time 10m
128technology · Jan 8, 2025 · d61a5db · d61a5db
1 parent ea906a1
commit d61a5db
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/plugins/inputs/t128_tank/reader.go b/plugins/inputs/t128_tank/reader.go
@@ -272,7 +272,7 @@ parseLoop:
 		messages, parseErr = parseLines(tankReader, r.topic)
 		if parseErr != nil {
 			r.log.Errorf("encountered error while parsing lines in %s output, will not attempt to parse more lines: %v", r.topic, parseErr)
-			break parseLoop
+			return parseErr
 		}
 		var collectedMessages []IndexedMessage
 		for _, message := range messages {
@@ -284,14 +284,13 @@ parseLoop:
 			break parseLoop
 		case r.sendChan <- collectedMessages:
 		}
-
-		if cmdErr := cmd.Wait(); cmdErr != nil {
-			var exitErr *exec.ExitError
-			if errors.As(cmdErr, &exitErr) {
-				r.log.Errorf("%s tank read command exited with error: %s", r.topic, exitErr.Error())
-			} else {
-				r.log.Errorf("%s tank read command exited with error: %s", r.topic, cmdErr)
-			}
+	}
+	if cmdErr := cmd.Wait(); cmdErr != nil {
+		var exitErr *exec.ExitError
+		if errors.As(cmdErr, &exitErr) {
+			r.log.Errorf("%s tank read command exited with error: %s", r.topic, exitErr.Error())
+		} else {
+			r.log.Errorf("%s tank read command exited with error: %s", r.topic, cmdErr)
 		}
 	}