Add global lock for syslog structured output conversion to avoid bug #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenMatase
requested review from
gregschrock,
agrawalkaushik and
shriyanshk128T
gregschrock
approved these changes
Dec 5, 2023
|
I think Shri's changes are in the release branch right now. This fix might be held up by that unless we work around it somehow. |
BenMatase
force-pushed
the
I95-54525-fix-syslog-output-corruption
branch
from
5286420 to
19a3a3a
Compare
BenMatase
changed the base branch from
release-128tech-1.22
to
release-128tech-1.22.6-temp
gregschrock
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the go-syslog code, there is global state causing concurrent messages being constructed to occasionally stomp on each other. I'm working on an upstream fix here, but in the meantime until that gets published, we want to prevent this from happening.