-
Notifications
You must be signed in to change notification settings - Fork 46
Don’t override fonts.conf #29
Comments
Ah, this will be better. I've got so much time in figuring out this fontconfig in the first place, I didn't think about the
Looking at
Starting the filename with 10 isn't correct. The Arch packages use a fontconfig starting with 35. I'd like to make the provided fontconfig file usable for both user-only and system-wide installs. This blocks #9 |
DejaVu uses 57 and 58:
Perhaps it should be 56? 59? 71? Since I created an "emoji" generic family, perhaps it makes sense to separate it into two files at 35 and 59? @edgemaster: Any thoughts? Why did you select 35 for the fontconfig filename? I'm doing some tests now and 35 works with |
I picked 35 as a bit of a guess, and roughly following the hints given in the fontconfig system readme. It is the priority of the config file I was referring to previously when I said that I needed to test the arch system install further. I didn't have the time you track down/run through test cases for each of the relevant configuration bugs though. |
Ah ha! I will figure out a good way to do automated testing to make it easier to confirm. |
This looks good enough for confirming correct installation: $ fc-match -s sans | head -n2
Vera.ttf: "Bitstream Vera Sans" "Roman"
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
$ fc-match -s serif | head -n2
VeraSe.ttf: "Bitstream Vera Serif" "Roman"
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
$ fc-match -s "Emoji One Color" | head -n2
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
Vera.ttf: "Bitstream Vera Sans" "Roman"
$ fc-match -s "Bitstream Vera Sans" | head -n2
Vera.ttf: "Bitstream Vera Sans" "Roman"
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
$ fc-match -s mono | head -n2
VeraMono.ttf: "Bitstream Vera Sans Mono" "Roman"
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
$ fc-match -s monospace | head -n2
VeraMono.ttf: "Bitstream Vera Sans Mono" "Roman"
EmojiOneColor-SVGinOT.ttf: "Emoji One Color" "Regular"
I'm going to automate it into a tests.sh |
@edgemaster I've made a
|
Awesome. I'll give it a whirl and see how tweaking the priority of the configuration file impacts things. |
I've changed the file to The user installer has been updated to put the file in @frederik-elwert I still need to backup the user's existing |
The provided font config was being installed at: ~/.config/fontconfig/fonts.conf it is better to install at: ~/.config/fontconfig/conf.d/56-emojione-color.conf Adds uninstall.sh Fixes #29
The provided font config was being installed at: ~/.config/fontconfig/fonts.conf it is better to install at: ~/.config/fontconfig/conf.d/56-emojione-color.conf Adds uninstall.sh Fixes #29
Installing at 56 causes many fonts in Firefox to become Bitstream, even when specified to be otherwise. For example, the UI flow of the GitHub webpages is broken with Bitstream. Trying to work out how CSS font selectors interact with the system fallbacks... |
Apologies for the noise, I'm describing #31. |
Currently, the install script overrides the file $HOME/.config/fontconfig/fonts.conf (after creating a backup). This might break other customisations of font configuration that a user did before. But fontconfig also supports a more modern approach of independent configuration files. So instead of overriding fonts.conf, I would suggest adding a file 10-emojione.conf to $HOME/.config/fontconfig/conf.d/.
The text was updated successfully, but these errors were encountered: