[eslint config] [base] [breaking] enable import/newline-after-import

Per import-js/eslint-plugin-import#386 / import-js/eslint-plugin-import#441
15Prospects · Jan 22, 2017 · e6bdeaa · e6bdeaa
1 parent 9d1f2bc
commit e6bdeaa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/eslint-config-airbnb-base/package.json b/packages/eslint-config-airbnb-base/package.json
@@ -48,13 +48,13 @@
     "babel-tape-runner": "^1.3.1",
     "eslint": "^3.1.1",
     "eslint-find-rules": "^1.11.1",
-    "eslint-plugin-import": "^1.11.0",
+    "eslint-plugin-import": "^1.11.1",
     "tape": "^4.6.0",
     "in-publish": "^2.0.0"
   },
   "peerDependencies": {
     "eslint": "^3.1.1",
-    "eslint-plugin-import": "^1.11.0"
+    "eslint-plugin-import": "^1.11.1"
   },
   "engines": {
     "node": ">= 4"

diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js
@@ -118,8 +118,7 @@ module.exports = {
 
     // Require a newline after the last import/require in a group
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md
-    // TODO: enable when https://github.com/benmosher/eslint-plugin-import/issues/386 is resolved
-    'import/newline-after-import': 0,
+    'import/newline-after-import': 2,
 
     // Require modules with a single export to use a default export
     // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md