Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added methods to allow for fine-tuned animation control #169

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Added methods to allow for fine-tuned animation control #169

merged 1 commit into from
Apr 10, 2020

Conversation

VictorKoenders
Copy link
Contributor

I decided to implement two methods, one for (set_)current_frame_index and one for (set_)current_frame_time, because I'd imagine that a developer wants to be able to manipulate both.

Closes #168

@17cupsofcoffee
Copy link
Owner

17cupsofcoffee commented Apr 10, 2020 •
edited
Loading

Looks good! I think I'll probably stick with this API as is, can't think of anything I'd want to change.

Also ignore the check failures, that's an issue with the repo config that I need to fix.

@17cupsofcoffee 17cupsofcoffee merged commit d0e7066 into 17cupsofcoffee:master Apr 10, 2020
@VictorKoenders VictorKoenders deleted the animation_frame_index branch April 10, 2020 14:17
@17cupsofcoffee
Copy link
Owner

Thanks again 😄

@VictorKoenders VictorKoenders restored the animation_frame_index branch August 5, 2020 07:09
@VictorKoenders VictorKoenders deleted the animation_frame_index branch August 5, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility to transfer the current_frame field between animations
2 participants
@VictorKoenders @17cupsofcoffee