Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for stencils #261

Merged
merged 11 commits into from
May 9, 2021
Merged

add support for stencils #261

merged 11 commits into from
May 9, 2021

Conversation

tesselode
Copy link
Contributor

Acknowledgements:

Copy link
Owner

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy with this API! Seems to give all the low level control people would need without being super verbose (think the StencilState methods help a lot with that).

More importantly, I can kinda understand what the stencil example is doing, despite not being very knowledgable about OpenGL stencils, which is a good sign, I think.

As discussed yesterday, my only real concern is the change to Canvas::new (due to it being a breaking change, and the fact that it adds extra typing/imports even when you're not using this feature). For now, I'll probably tweak the changes to be non-breaking, and then revisit that when I come to do 0.7.

@17cupsofcoffee 17cupsofcoffee merged commit cec3d70 into 17cupsofcoffee:main May 9, 2021
@17cupsofcoffee
Copy link
Owner

Thank you again for the PR! 🚀

@tesselode
Copy link
Contributor Author

of course!

@17cupsofcoffee
Copy link
Owner

FYI - I just pushed a commit changing CanvasSettings into a builder, as otherwise it wouldn't be possible to add extra settings (e.g. depth buffers, texture formats, mipmaps) without each one being a breaking change. Should still be basically the same amount of typing (minus one import, which is kinda nice), but a bit more future proof.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants