-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for stencils #261
Conversation
more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really happy with this API! Seems to give all the low level control people would need without being super verbose (think the StencilState
methods help a lot with that).
More importantly, I can kinda understand what the stencil example is doing, despite not being very knowledgable about OpenGL stencils, which is a good sign, I think.
As discussed yesterday, my only real concern is the change to Canvas::new
(due to it being a breaking change, and the fact that it adds extra typing/imports even when you're not using this feature). For now, I'll probably tweak the changes to be non-breaking, and then revisit that when I come to do 0.7.
Thank you again for the PR! 🚀 |
of course! |
FYI - I just pushed a commit changing |
Acknowledgements:
StencilState
struct