Dev --> master #2112
Merged
Dev --> master #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve build times for blogs
Revised "Hire 18F" content
Project intros
houndci-bot
reviewed
Dec 9, 2016
| ] | ||
|
|
||
| stripped_post_directory.each_with_index do |post, index| | ||
| if !lines.include? "- #{post}\n" and !acceptable_indices.include? index |
There was a problem hiding this comment.
Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Use && instead of and.
Add project-page links to what we deliver, revise HHS intro
gemfarmer
commented
Dec 9, 2016
| @@ -1,10 +1,3 @@ | |||
| GIT | |||
There was a problem hiding this comment.
These changes need to be reverted before merging
|
LGTM! !! |
Updated developer page and fixed link in one year in review blog post
|
@gboone This look okay to merge? |
gboone
approved these changes
Dec 13, 2016
|
@gboone Is it time to press the big 🍏 button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 PREVIEW
Changes proposed in this pull request:
./serve-blogscript/cc @coreycaitlin