This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
[Delivers #89433964] File upload #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ gem 'acts_as_list' | |||
| gem 'ar_outer_joins' | |||
| gem 'autoprefixer-rails' | |||
| gem 'awesome_print' | |||
| gem 'aws-sdk-v1' | |||
There was a problem hiding this comment.
Why v1? aws-sdk is the newer one, which it seems like Paperclip supports.
There was a problem hiding this comment.
Not quite yet: thoughtbot/paperclip#1764
There was a problem hiding this comment.
Far enough. Mind adding an inline comment linking to that issue?
added 2 commits
April 20, 2015 21:20
| <div class='row text-area-info-container'> | ||
| <div class='col-xs-7 col-sm-6 text-area-info-web'> | ||
| <p> | ||
| Attaching a file will associate it with this proposal |
There was a problem hiding this comment.
Minor: seems like this would be obvious...no?
There was a problem hiding this comment.
Changing to "Attach a file (e.g. receipts, contract documents, etc.)"
|
A few suggestions, but no blockers. Branch-deploying. |
|
afeld
added a commit
that referenced
this pull request
Apr 21, 2015
[Delivers #89433964] File upload
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds paperclip and an attachments model to allow file uploading. This will use S3 if the appropriate environmental variables are set (namely a bucket name, the private, and public key).
Also generalized some styles to work with file uploads as well as comments.
Looks like:
