Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check over all custom rate limit records to ensure there are no duplicates #305

Closed
GUI opened this issue Jan 6, 2016 · 1 comment
Closed

Comments

@GUI
Copy link
Member

GUI commented Jan 6, 2016

See #303 and #304. Since duplicate rate limit records defined on users may have unexpectedly popped up when making edits, and this then leads to unexpected behavior,we should check the records in our database to ensure nobody else has accidentally run into this and not noticed.

@GUI
Copy link
Member Author

GUI commented Jan 7, 2016

In fixing #306, I discovered that the root cause for these different rate limit bugs was a change I made that got rolled out during the larger Lua-ralated upgrades (#294). See NREL/api-umbrella@af74645 for more detail.

It's unfortunate we didn't catch this earlier, but this at least means it's only been broken since November, and not for forever as I was initially fearing (and also confused as to how we hadn't seen this before). This means that when we check for problematic records, we should only see possible issues in records modified after mid November. However, it's probably still worth checking everything while we're at it, just to be doubly sure.

@GUI GUI closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant