Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove custom rate limit entries from user form #306

Closed
GUI opened this issue Jan 6, 2016 · 1 comment
Closed

Can't remove custom rate limit entries from user form #306

GUI opened this issue Jan 6, 2016 · 1 comment
Assignees
Labels

Comments

@GUI
Copy link
Member

GUI commented Jan 6, 2016

If an API user is added with custom rate limits, you can't remove individual custom rate limits from the table by editing the record. You can click the "Remove" button next to an individual limit and after confirming removal, it disappears from the interface, but after saving the record, the removed entires are still present after reloading.

Oddly, the removal action does work on the custom rate limits defined on API Backends, it's just on the API Users from where this is broken. There were some subtle differences in edits due to #303, but with that fixed, I'm not quite sure what's causing the differences in behavior between the two forms since they both use the same underlying Settings model. Need to investigate more, but it seems to be something more related to the model setup and the Rails accepts_nested_attributes_for behavior.

@GUI GUI added the bug label Jan 6, 2016
@GUI GUI self-assigned this Jan 6, 2016
@GUI
Copy link
Member Author

GUI commented Jan 7, 2016

Fixed by NREL/api-umbrella@af74645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant