This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
Fixes #116 - set cookie domain via COOKIE_DOMAIN #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cookie domain for the authentication cookie that conveys a token from the backend to the frontend after a SAML sign-on defaults to `API_REDIRECT` but can be optionally set via the `COOKIE_DOMAIN` environment variable.
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 90.07% 90.07%
=======================================
Files 581 581
Lines 12881 12881
Branches 3535 3535
=======================================
Hits 11603 11603
Misses 1024 1024
Partials 254 254Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie domain for the authentication cookie that conveys a token from the backend to the frontend after a SAML sign-on defaults to
API_REDIRECTbut can be optionally set via theCOOKIE_DOMAINenvironment variable.