Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Fix missing checkmarks for sidenav and input fields #1661

Merged
merged 2 commits into from
May 21, 2019

Conversation

joshmfranklin
Copy link
Contributor

@joshmfranklin joshmfranklin commented May 21, 2019

This fixes the missing checkbox icon from the sidenav and input fields. We had added $asset-path to the eqip.scss file to get the stylesheets working for Storybook, however this change added an extra / to the asset path in the app. This caused the icon url to be invalid.

This change does cause the styles to not load on Storybook.

@suzubara
Copy link
Contributor

Instead of removing the / from $asset-path, I removed it from the CSS that references $asset-path. I also added some stories for the SectionLink component in order to verify the icon shows up in both the app & storybook.

@joshmfranklin joshmfranklin merged commit 57801ec into develop May 21, 2019
@joshmfranklin joshmfranklin deleted the jf-remove-asset-path branch May 21, 2019 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants