This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
Get test case 7 validating against schemas #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #847 +/- ##
===========================================
+ Coverage 46.66% 46.75% +0.09%
===========================================
Files 680 680
Lines 27397 27427 +30
Branches 3371 3371
===========================================
+ Hits 12784 12824 +40
+ Misses 14250 14242 -8
+ Partials 363 361 -2
Continue to review full report at Codecov.
|
JSON has several phantom and 2 real validation errors. XML has 33 XSD validation errors. Submitting to e-QIP indicates 74 exception errors.
Military addresses are encoded differently when under an APOAFO element vs when they are in a multi-purpose Address element.
Work-around for #859
Work-around for #860
Work-around for #863
Work-around for #868
6bb48af
to
4fc0db7
Compare
#848 corrected logic where frequency/method/etc. of contact wasn't been collected before
hursey013
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chips away at #744