Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Get test case 7 validating against schemas #847

Merged
merged 12 commits into from
Sep 27, 2018
Merged

Get test case 7 validating against schemas #847

merged 12 commits into from
Sep 27, 2018

Conversation

ryanhofdotgov
Copy link
Contributor

@ryanhofdotgov ryanhofdotgov commented Sep 22, 2018

Chips away at #744

@codecov
Copy link

codecov bot commented Sep 22, 2018

Codecov Report

Merging #847 into develop will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #847      +/-   ##
===========================================
+ Coverage    46.66%   46.75%   +0.09%     
===========================================
  Files          680      680              
  Lines        27397    27427      +30     
  Branches      3371     3371              
===========================================
+ Hits         12784    12824      +40     
+ Misses       14250    14242       -8     
+ Partials       363      361       -2
Flag Coverage Δ
#backend 8.01% <100%> (+0.25%) ⬆️
#frontend 90.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
api/location.go 0% <ø> (ø) ⬆️
api/xml/xml.go 87.8% <100%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20eca41...301f833. Read the comment docs.

JSON has several phantom and 2 real validation errors.
XML has 33 XSD validation errors.
Submitting to e-QIP indicates 74 exception errors.
Military addresses are encoded differently when under an APOAFO
element vs when they are in a multi-purpose Address element.
Work-around for #859
#848 corrected logic
where frequency/method/etc. of contact wasn't been collected before
@ryanhofdotgov ryanhofdotgov changed the title [WORK IN PROGRESS] Prepare and submit test case 7 Get test case 7 validating against schemas Sep 27, 2018
@hursey013 hursey013 merged commit dba2836 into develop Sep 27, 2018
@hursey013 hursey013 deleted the initial-test7 branch September 27, 2018 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants