Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Catch lowercase states in location validator #904

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

hursey013
Copy link
Contributor

The lowercase states were throwing off the initial validation when trying to find the state in the object of zip codes.

@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #904 into develop will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #904     +/-   ##
==========================================
- Coverage    46.75%   46.66%   -0.1%     
==========================================
  Files          680      680             
  Lines        27427    27398     -29     
  Branches      3371     3372      +1     
==========================================
- Hits         12824    12785     -39     
- Misses       14242    14250      +8     
- Partials       361      363      +2
Flag Coverage Δ
#backend 7.75% <ø> (-0.26%) ⬇️
#frontend 90.19% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/validators/location.js 74.54% <100%> (+0.23%) ⬆️
api/xml/xml.go 85.62% <0%> (-2.19%) ⬇️
api/location.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba2836...a4d525b. Read the comment docs.

Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@apburnes apburnes merged commit abb1f9e into develop Sep 27, 2018
@ryanhofdotgov ryanhofdotgov deleted the bh_zip_state_location branch September 27, 2018 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants