Skip to content
This repository has been archived by the owner on Sep 19, 2021. It is now read-only.

Update addresses to display only APO/FPO when required #908

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Sep 28, 2018

Closes #861
Closes #899
Closes #863

Reviewed the validation matrix and sf86 form to verify all the applicable APO/FPO address fields.

List of effected sections and subsections.

- Where have you lived
- Employment Activities 
  - Employer Address
  - Supervisor Address
- Marital/Relationship Status
  - Civil union (together or separated) resident address
- Foreign Contacts
  - Resident address
- Relatives
  - Resident address not deceased living in the united states 

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #908 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #908   +/-   ##
========================================
  Coverage    46.75%   46.75%           
========================================
  Files          680      680           
  Lines        27428    27428           
  Branches      3372     3372           
========================================
  Hits         12825    12825           
  Misses       14242    14242           
  Partials       361      361
Flag Coverage Δ
#backend 8.01% <ø> (ø) ⬆️
#frontend 90.19% <ø> (ø) ⬆️
Impacted Files Coverage Δ
.../Section/SubstanceUse/Drugs/VoluntaryTreatment.jsx 100% <ø> (ø) ⬆️
...nts/Section/History/Employment/PhysicalAddress.jsx 100% <ø> (ø) ⬆️
...components/Section/History/Federal/FederalItem.jsx 100% <ø> (ø) ⬆️
...ents/Section/Legal/Technology/UnauthorizedItem.jsx 100% <ø> (ø) ⬆️
...ponents/Section/Foreign/Activities/SupportItem.jsx 100% <ø> (ø) ⬆️
...ents/Section/Legal/Technology/ManipulatingItem.jsx 100% <ø> (ø) ⬆️
...nents/Section/Foreign/Business/SponsorshipItem.jsx 94.11% <ø> (ø) ⬆️
...onents/Section/History/Residence/ResidenceItem.jsx 60.27% <ø> (ø) ⬆️
...ts/Section/SubstanceUse/Drugs/OrderedTreatment.jsx 94.28% <ø> (ø) ⬆️
...ts/Section/Financial/Delinquent/DelinquentItem.jsx 97.05% <ø> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c685a...9ed5423. Read the comment docs.

Copy link
Contributor

@hursey013 hursey013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran against test scenarios and did not see any validation issues.

@hursey013
Copy link
Contributor

Does this also resolve #899 and #863 now that APO is off by default?

@apburnes
Copy link
Contributor Author

@hursey013 it looks like it does.

Copy link
Contributor

@ryanhofdotgov ryanhofdotgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the SF-86 is a bit tricky in this regard and this doesn't quite get what we need.

While this correctly enables APO/FPO for all the places where the schema has an element called "APOFPO" (encoding it with Address/ZipCode/ApoFpo/State), there are about ~40 other places where APO/FPO addresses are allowed (but encoded in an "Address" element with Street/City/ZipCode/State).

Per #861, the way you can find these other places are to go through the XSD all look for Address/State elements with a type of "AllStates". This is contrast to Address/State elements that have a type of "NoMilitaryStates". In the SF-86 pdf you can see the difference in the drop-downs they embed in the form – some of them have the military states like AA, AE, etc. while others don't.

As Andrew is back on his regularly scheduled program, @hursey013 can you take this over the finish line?

@ryanhofdotgov ryanhofdotgov changed the title Update addresses to display only APO/FPO when required [WORK IN PROGRESS] Update addresses to display only APO/FPO when required Oct 2, 2018
@hursey013
Copy link
Contributor

hursey013 commented Oct 2, 2018

@ryanhofdotgov updated after cross referencing XSD and validation matrix for items allowing military states.

@hursey013
Copy link
Contributor

Also I have confirmed that this will fix #899 and #863 since the default is now showPostOffice={false}, any Location component that doesn't specifically opt-in will have APO/FPO off by default. I will update the description of this PR to reference these tickets as well so they are closed automatically once this is approved.

@ryanhofdotgov ryanhofdotgov changed the title [WORK IN PROGRESS] Update addresses to display only APO/FPO when required Update addresses to display only APO/FPO when required Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants