-
Notifications
You must be signed in to change notification settings - Fork 22
Update addresses to display only APO/FPO when required #908
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #908 +/- ##
========================================
Coverage 46.75% 46.75%
========================================
Files 680 680
Lines 27428 27428
Branches 3372 3372
========================================
Hits 12825 12825
Misses 14242 14242
Partials 361 361
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ran against test scenarios and did not see any validation issues.
@hursey013 it looks like it does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the SF-86 is a bit tricky in this regard and this doesn't quite get what we need.
While this correctly enables APO/FPO for all the places where the schema has an element called "APOFPO" (encoding it with Address/ZipCode/ApoFpo/State), there are about ~40 other places where APO/FPO addresses are allowed (but encoded in an "Address" element with Street/City/ZipCode/State).
Per #861, the way you can find these other places are to go through the XSD all look for Address/State elements with a type of "AllStates". This is contrast to Address/State elements that have a type of "NoMilitaryStates". In the SF-86 pdf you can see the difference in the drop-downs they embed in the form – some of them have the military states like AA, AE, etc. while others don't.
As Andrew is back on his regularly scheduled program, @hursey013 can you take this over the finish line?
@ryanhofdotgov updated after cross referencing XSD and validation matrix for items allowing military states. |
Also I have confirmed that this will fix #899 and #863 since the default is now |
Closes #861
Closes #899
Closes #863
Reviewed the validation matrix and sf86 form to verify all the applicable APO/FPO address fields.
List of effected sections and subsections.