Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uppercase transform from navbar styles #249

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Sep 10, 2021

Why: Per Figma design system "Layouts and templates". This is already applied to the brochure site via style override, and reflected in upcoming Partnerships site design.

Before After
image image

@aduth aduth requested a review from nickttng September 10, 2021 20:51
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

**Why**: Per Figma design system "Layouts and templates". This is already applied to the brochure site via [style override](https://github.com/18F/identity-site/blob/25d5b444c3b8852b5000721837e84aef75a92512/_sass/components/_nav.scss#L191), and reflected in upcoming Partnerships site design.
@aduth aduth force-pushed the aduth-navbar-rm-text-transform branch from 4182869 to 8dbb6ad Compare September 13, 2021 19:31
@aduth aduth merged commit d6ab71e into main Sep 13, 2021
@aduth aduth deleted the aduth-navbar-rm-text-transform branch September 13, 2021 19:59
@aduth aduth mentioned this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants