Badge: Improve visual appearance and accessibility, simplify markup #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: - Improved vertical centering - Removed unused ID attribute - Removed unnecessary `<span>` child to simplify markup and improve performance in deeply-nested markup documents - Set null icon alt to treat as decorative / redundant, based on adjacent text providing the same information. - Remove broken responsive styling
aduth
commented
Sep 17, 2021
| } | ||
| } | ||
|
|
||
| @media #{$theme-site-margins-breakpoint} { |
There was a problem hiding this comment.
$theme-site-margins-breakpoint comes from USWDS and is equal to the string value "desktop" (source). @media desktop { is not a valid media query. This would have needed to use the at-media mixin to do anything. Based on the styles, I'm assuming this is meant to address some of the IdP-specific styling of verification badges as right-aligned on the account page at desktop viewports. Since it's project-specific, I don't think it's appropriate to keep.
mdiarra3
approved these changes
Sep 17, 2021
|
Test failure is for visual regression, and is expected based on how the icon placement has been adjusted slightly to improve vertical centering:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<span>child to simplify markup and improve performance in deeply-nested markup documents