Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade USWDS to 2.13.1 #280

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Upgrade USWDS to 2.13.1 #280

merged 1 commit into from
Jan 20, 2022

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 20, 2022

Why: To use latest features, improvements, and bug fixes.

Notably, this includes the luminance function improvements that had been temporarily patched as part of #278 and can now be removed.

Release notes: https://github.com/uswds/uswds/releases/tag/v2.13.1

**Why**: To use latest features, improvements, and bug fixes.

Notably, this includes the `luminance` function improvements that had been temporarily patched as part of #278 and can now be removed.

Release notes: https://github.com/uswds/uswds/releases/tag/v2.13.1
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member Author

aduth commented Jan 20, 2022

The visual regression failure here isn't necessarily expected, though probably related to the external link changes mentioned in the release notes (uswds/uswds#4439).

image

@aduth aduth merged commit cc43fee into main Jan 20, 2022
@aduth aduth deleted the aduth-uswds-2-13-1 branch January 20, 2022 21:51
@aduth aduth mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants