Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename project to identity-design-system, scope package to 18F #331

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Rename project to identity-design-system, scope package to 18F #331

merged 2 commits into from
Apr 3, 2023

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 10, 2023 •
edited
Loading

  • Improve discoverability for people searching for the Login.gov Design System
  • Scope package to organization to adhere to best practices

Follow-up:

  • Rename repository in GitHub repository settings.
  • Consider resetting version count to 1.0.0 in package.json

@aduth aduth requested a review from nickttng March 10, 2023 16:54
zachmargolis
zachmargolis reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Consider resetting version count to 1.0.0 in package.json

I think it makes sense to keep the numbers going up, because it's the same git repo with the same history

@aduth
Copy link
Member Author

aduth commented Mar 14, 2023

Consider resetting version count to 1.0.0 in package.json

I think it makes sense to keep the numbers going up, because it's the same git repo with the same history

Yeah, on second thought, a reset is probably not worth it. It also runs contrary to my own reluctance to accept "big major version = bad", we aren't at risk of running out of numbers.

@aduth aduth force-pushed the aduth-rename-design-system branch 2 times, most recently from 7bad8e6 to 95e1344 Compare March 14, 2023 19:40
This was referenced Mar 22, 2023
Merged
Merged
@aduth
Copy link
Member Author

aduth commented Apr 3, 2023

Renaming the repository might require some more work, so I'm going to limit the changes to package references for now and merge.

@aduth aduth force-pushed the aduth-rename-design-system branch from 9de3fd3 to decd9cc Compare April 3, 2023 12:31
@aduth aduth merged commit 0cdb7f2 into main Apr 3, 2023
@aduth aduth deleted the aduth-rename-design-system branch April 3, 2023 12:38
@aduth aduth mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickttng nickttng nickttng approved these changes

@zachmargolis zachmargolis zachmargolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aduth @zachmargolis @nickttng