LG-15612 Load reCAPTCHA script earlier in the page #11880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsmaster5
commented
Feb 14, 2025
| @@ -1,5 +1,6 @@ | |||
| <%= content_for(:head) do %> | |||
| <%= javascript_include_tag('init.js', nopush: false, integrity: 'sha256-eMXV2njRJxgQrFbuljRT/UTWePGrhl83bHHDDd+jFPw=') %> | |||
| <%= render CaptchaScriptComponent.new %> | |||
There was a problem hiding this comment.
I don't think we want this on every page.
There was a problem hiding this comment.
Did you try using content_for inside the existing component?
There was a problem hiding this comment.
That was right there in the Technical notes! 😢 I have now and it seems to be working smashingly.
There was a problem hiding this comment.
Added to content_for with 7d1ac2b
Fixed up tests from slack conversation with 10eba3a
aduth
reviewed
Feb 18, 2025
kevinsmaster5
force-pushed
the
kmas-lg-15612-load-reaptcha-script-earlier
branch
from
0d82c16 to
97755d0
Compare
aduth
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15612
🛠 Summary of changes
Moves the reCAPTCHA script to the document head. Adds a new Yield area in the base html template so the script occurs before the stylesheets are loaded.
The intent is to optimize loading of the reCAPTCHA initializer to improve accuracy of scoring.
📜 Testing Plan
Prerequisite config settings
In application.yml set placeholder values for
recaptcha_secret_keyandrecaptcha_site_keyTo test if enterprise script loads set a value for
recaptcha_enterprise_api_keyandrecaptcha_enterprise_project_idhttps://www.google.com/recaptcha/api.jsscript appears near the top just after the fonts are loaded and before the style sheets.https://www.google.com/recaptcha/enterprise.js