Merge 3rd and 4th screens in mobile IAL2 flow (LG-3962) #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
force-pushed
the
mitchellhenke/mobile-doc-auth-merge-lg-3962
branch
from
a959351 to
6aaecb3
Compare
aduth
reviewed
Jan 28, 2021
|
|
||
| return ( | ||
| <> | ||
| <p className="sm-hide">{t('doc_auth.info.upload_mobile')}</p> |
There was a problem hiding this comment.
I don't have particularly strong feelings about using DeviceContext's isMobile property here, but worth noting:
- It isn't quite the same as just a media query, since it considers camera capability (source). This becomes relevant for things like whether we optimize actions for assuming that "Take Photo" would launch the Acuant SDK experience, vs. a standard file upload input.
- It's also primarily how we control rendering differences from the tests, by assigning device context one way or the other depending on the type of view we want to emulate.
I think if we're to use a class, I'd at least eventually like to see sm-hide go away altogether, in favor of responsive display classes (display-none desktop:display-block). We're sometimes blocked by LG-3863 for this, due to how BassCSS uses !important for its display-none class.
There was a problem hiding this comment.
This was the spot I was most unsure about. I think replacing the sm-hide with isMobile makes the most sense.
mitchellhenke
force-pushed
the
mitchellhenke/mobile-doc-auth-merge-lg-3962
branch
3 times, most recently
from
a4a38f0 to
67b7946
Compare
mitchellhenke
force-pushed
the
mitchellhenke/mobile-doc-auth-merge-lg-3962
branch
from
67b7946 to
4bfbaf6
Compare
aduth
reviewed
Jan 28, 2021
app/javascript/packages/document-capture/components/document-capture.jsx
Outdated
Show resolved
Hide resolved
spec/javascripts/packages/document-capture/components/document-capture-spec.jsx
Outdated
Show resolved
Hide resolved
|
Nit: Maybe we should update this comment to say "in the introduction" instead of "on the introductory step", since the step is being removed: |
…apture.jsx Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
changed the title
mitchellhenke
added a commit
that referenced
this pull request
Feb 4, 2021
* Make AgencySeeder ignore the abbreviation attribute (#4617) Temporarily ignore the abbreviation attribute in agencies.yml to allow the config repo updates to be merged without breaking the IdP while we work on adding the Partnerships data model to the IdP schema. We will ultimately add the attribute to the `agencies` table and at that point remove this change. Also updates the localdev template YAML file and adds an explicit fixture file for testing, which is passed to the service object through dependency injection. * Add feature flag to send partial DOB to LexisNexis (LG-3706) (#4613) * Bump identity-proofer-gem to get Proofer::Result#transaction_id (#4624) * LG-4129: Add test case for cancelled IAL2 session (#4621) **Why**: Follow-up task from #4620 (comment) * LG-4097: Fix "Submit" button always appearing disabled on document capture review step (#4623) * Omit unknown errors when considering to allow step continue **Why**: Active errors contains both field-specific and general messages, e.g. received from a failed validation attempt. The latter will never become unresolved by changing field values. Only disable continue if the step is invalid OR if there are field-specific errors yet to be addressed. * Add ReviewIssuesStep validator * Fix lint error * Merge 3rd and 4th screens in mobile IAL2 flow (LG-3962) (#4626) * placeholder * remove mobile intro step * Update app/javascript/packages/document-capture/components/document-capture.jsx Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * update comment and remove unnecessary text * remove new line * fix merge Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Move phone internationalization scripts to intl-tel-input pack (#4622) **Why**: Reduce size of main application bundle, which is loaded in all paths. Phone validation dependencies are quite large, and are only used in the context of the intl-tel-input pack (screens with phone input). * Add separate feature flag to disable VOIP checks entirely (#4629) * Retire the remote settings tooling (#4619) The remote setting tooling was added at a time when `service_providers.yml` was tracked in the IdP codebase. At that time it was not possible to update the configs for a service provider without changing the IdP code and deploying a new sha. With identity-idp-config, this is no longer true. This commit removes the code since now we can modify service provider configs by updating identity-idp-config and recycling to apply the changes. * Drop doc_captures table (#4519) **Why**: Because after #4508 is merged, we won't be using this table. We will be using document_capture_sessions instead. * LG-4114 Log Async Timeout events (#4618) * remove access rejected when capturing video (#4636) * LG-3769: Optimize image assets (#4635) * Add image optimization lint task * Remove "data-name" attribute from SVG * Optimize images * Restore keyframes to ID card SVG **Why**: Bug with SVGO removes keyframes. Comments are ignored by default, which are necessary for allowable exceptions to SVG inline styles. SVGO's `removeComments` will preserve comments prefixed with an exclamation point. See: svg/svgo#888 See: https://github.com/svg/svgo/blob/master/plugins/removeComments.js * Compress PNG images * Update lambda ref to get x-ray tracing functionality (#4637) * remove aal field from service_provider (LG-4119) (#4612) * remove aal field from service_provider * make remove_column reversible * Fix image upload 500 (LG-4154) (#4640) * add specs * do not attempt throttling if document capture session does not exist * do not raise exception on null byte in OIDC token code (#4641) * Remove migration that drops the AAL column (#4642) * Revert "remove aal field from service_provider (LG-4119) (#4612)" This reverts commit c9ce970. * Add AAL to the ignored column **Why**: We will be dropping this column in a future commit * Update proofer gem (#4646) **Why**: This version includes support for non-string attributes Co-authored-by: Oren Kanner <oren.kanner@gsa.gov> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Steve Urciuoli <steve.urciuoli@gsa.gov> Co-authored-by: Doug Price <douglas.price@gsa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Mobile Flow
New Desktop Flow
New Hybrid Flow