Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.5% delivered as .12 in API #1369

Closed
colinmurphy01 opened this issue Oct 6, 2021 · 3 comments
Closed

12.5% delivered as .12 in API #1369

colinmurphy01 opened this issue Oct 6, 2021 · 3 comments
Labels

Comments

@colinmurphy01
Copy link

Currently:
When a person logs a timecard with 12.5% allocation submitted, it's stored and delivered via the Timecard API as .12 with "project_allocation". If total cost per week = project_allocation * proration (based on OOO) then rounding down to .12 from .125, we end up not charging $50.

Expected:
When a person logs 12.5% it's stored and delivered as .125 in the API

@colinmurphy01
Copy link
Author

We are currently converting .12 to .125 in the google sheets temporarily, but it's a temporary fix.

@caleywoods
Copy link

@colinmurphy01 I've opened #1370 to fix this. I just need to test the endpoint and make sure it's actually fixed and try to get #1368 resolved as well since it's kind of blocking pull requests at the moment.

@caleywoods
Copy link

Resolved by #1370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants