Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project_allocation API scale/precision #1370

Merged
merged 10 commits into from
Oct 8, 2021

Conversation

caleywoods
Copy link

@caleywoods caleywoods commented Oct 6, 2021

Description

Addresses #1369. Update the scale/precision of the project_allocation field in the API return for Timecards. The TimecardSerializer just needed updated to reflect the scale and precision change that was made to support 12.5% (0.125) project allocation.

@caleywoods caleywoods marked this pull request as draft October 6, 2021 21:29
@codecov-commenter
Copy link

Codecov Report

Merging #1370 (075e9ad) into main (d50b616) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files          51       51           
  Lines        2242     2242           
=======================================
  Hits         2016     2016           
  Misses        226      226           
Impacted Files Coverage Δ
hours/models.py 97.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50b616...075e9ad. Read the comment docs.

@caleywoods caleywoods changed the title WIP Update project_allocation API scale/precision Update project_allocation API scale/precision Oct 7, 2021
@caleywoods caleywoods marked this pull request as ready for review October 7, 2021 21:40
Copy link
Contributor

@kfoley-18F kfoley-18F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

@kfoley-18F kfoley-18F merged commit 611fc56 into main Oct 8, 2021
@kfoley-18F kfoley-18F deleted the caleywoods/api-proj-allocation-fix branch October 8, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants