Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportingPeriodUserDetailView cleanup, utilization calculation update #1072

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

timoballard
Copy link
Member

Description

Makes the tables displayed in ReportingPeriodUserDetailView more readable and updates the utilization calculation to match other parts of the application.

resolves #1056
resolves #1058

Additional information

image

Copy link
Contributor

@tbaxter-18f tbaxter-18f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looks like a minor lint thing is making circle fail:
./hours/views.py:29:1: F401 'utilization.utils.calculate_utilization' imported but unused

@tbaxter-18f tbaxter-18f merged commit b2c9f8f into master Apr 28, 2020
@Jkrzy Jkrzy deleted the tock-1056-1058_reporting_period_detail branch May 1, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render tables consistently across site Remove vestigial utilization views and reporting
2 participants