Replace if_18f_employee field with property #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we move towards Organization being a required field, we drop this indepdent field and replace with a property whose value is derived from Organization.
tbaxter-18f
approved these changes
May 5, 2020
Updating so we always return True or False and clarifying test case a bit.
Description of billable_expectation belongs in help_text, not as the verbose field name. Also adding another filter to the UserData admin to assist survey/inspection.
timoballard
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #1034, dropping
is_18f_employeefrom UserData model.As we move towards Organization being a required field, we drop this independent field and replace with a property whose value is derived from Organization.
We'll no longer have to maintain a separate field in addition to Organization in order to serve data re: a user being in 18F or not.