Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple edit timecards - in-line edits for fields used in utilization calculations #1111

Merged
merged 7 commits into from
Jun 18, 2020

Conversation

cryptofilegsa
Copy link
Contributor

Description

Tock Admins can perform in-line edits for fields used in utilization calculations (billable_expectation, organization)

First half of the requests in issue #1105
#1105

Additional information

Include any of the following (as necessary):

  • modified column label for strength length sanity
  • testing -admin view is part of the inherent django framework

Copy link
Contributor

@Jkrzy Jkrzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cryptofilegsa! This looks great but we'll also need to generate a migration for those model changes.

@cryptofilegsa cryptofilegsa requested a review from Jkrzy June 18, 2020 14:48
Copy link
Contributor

@Jkrzy Jkrzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Jkrzy Jkrzy merged commit a6f476a into master Jun 18, 2020
@Jkrzy Jkrzy deleted the multiple-edit-timecards branch June 18, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants