Utilization Analytics MVP #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds the utilization module back into code coverage checking
Jkrzy
reviewed
Aug 3, 2020
Jkrzy
reviewed
Aug 3, 2020
Jkrzy
reviewed
Aug 5, 2020
| {% endblock %} | ||
|
|
||
| {% block content %} | ||
| <script src="https://cdn.plot.ly/plotly-latest.min.js"></script> |
There was a problem hiding this comment.
Let's bring this in house and serve ourselves for consistency by pulling the version we need into tock/tock/static/vendor
https://github.com/18F/tock/blob/main/docs/dependency-management.md#production
Jkrzy
reviewed
Aug 5, 2020
| def _utilization_data(start_date, end_date): | ||
| Timecard = apps.get_model("hours", "Timecard") | ||
| billable_filter = Q(timecardobjects__project__accounting_code__billable=True) | ||
| data = (Timecard.objects.filter(reporting_period__start_date__gte=start_date, |
There was a problem hiding this comment.
Opportunity here to limit this to submitted timecards by filtering on Timecard.submitted
|
Looks :amaze: @neilmb, thank you!! |
|
@Jkrzy Comments addressed: filter on submitted, vendor plotly into static, sum using existing billable/non-billable totals on timecard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is lots of valuable information about 18F operations in the Tock database. This is a very early step in making that data visible. It adds a page under "Reports" called "Analytics" that currently has just a single graph of the total hours billed over time broken down by billable and non-billable.
There are many more relevant graphs that could be added here in the future, but this is an MVP to establish that we can include these kinds of graphs.
Additional information
This adds a dependency on the python
plotlylibrary for creating the plots in a way that can be included in the template and the template for the page then includes the Plotly.js library on-page from their CDN. If we need to ship a fixed version of that JS library, we could figure out how to do that instead.