Default to graphing past 12 months #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jkrzy
reviewed
Aug 19, 2020
Jkrzy
reviewed
Aug 19, 2020
Jkrzy
reviewed
Aug 19, 2020
neilmb
force-pushed
the
nmb/analytics-improved
branch
from
dab65de
to
30554b6
Compare
|
Great catch @Jkrzy, fixed and ready for re-review. |
Jkrzy
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion on #1142 suggested using the past 12 months time frame by default. This changes the Analytics page to show the last year of data by default. It also adds a "tip" for the Start Date on what the earliest available data is.
Additional information
"Previous year" is a surprisingly complicated concept (12 months, 365 days, 1 calendar year?). This just subtracts 1 from today's year.