Fix our use of PermissionMixin #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @neilmb, this is nice move in the right direction. I don't think we need to address |
Jkrzy
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1138 @Jkrzy noticed that we were mis-using the
PermissionMixinclass with nopermission_classeswhich restricts nothing. This corrects that by usingLoginRequiredMixinin those cases and prevents it from happening again by making it an exception to usePermissionMixinwithout defining thepermission_classesattribute.Additional information
We could go further with this and replace all of the correct uses of
PermissionMixinwithpermission_classes = (IsAuthenticated, )byLoginRequiredMixinbut I haven't done that here. I'm willing though if people would prefer it.