Use preferred names for templates in Tock #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using django's provided `user.get_full_name` we now render full name, configurable in the admin, for display throughout Tock.
Also removing duplicated test `hours.test.test_views.test_project_timeline`
tbaxter-18f
reviewed
Dec 16, 2020
Codecov Report
@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
- Coverage 88.93% 88.22% -0.72%
==========================================
Files 51 51
Lines 2097 2097
==========================================
- Hits 1865 1850 -15
- Misses 232 247 +15
Continue to review full report at Codecov.
|
tbaxter-18f
reviewed
Jan 25, 2021
tbaxter-18f
reviewed
Jan 25, 2021
Jkrzy
commented
Jan 25, 2021
tbaxter-18f
reviewed
Jan 25, 2021
tbaxter-18f
reviewed
Jan 25, 2021
tbaxter-18f
reviewed
Jan 28, 2021
tbaxter-18f
reviewed
Jan 28, 2021
tbaxter-18f
reviewed
Jan 28, 2021
Sgtpluck
reviewed
Jan 28, 2021
* main: Remove requirements.txt
Since we're using UserData to get a display name, let's get them all on our first query instead each one individually.
tbaxter-18f
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Big round of 👏 for @Sgtpluck. Great job, especially as you're still learning your way around Django.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For #1027, we now render preferred names (First + Last) -- configurable via the admin panel -- for all pages in Tock.
This does not include changes to the API endpoints or data exports.
There's a handful of users (~9) who don't have a First/Last name value set -- We could handled with a bit more code here, rendering
usernameas a fallback OR updating these users in the admin.We should also update the Tock change form so folks can request a name update...OR create a form so folks can update it themselves