Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'warn' to 'warning' since 'warn' is being deprecated #1307

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

kewlguy781
Copy link
Contributor

Description

Resolves 1306

Additional information

The issue was raised during the test prior to update Django to 3.0 using this command python -Wa manage.py test (please see issue 1306). I also did a folder-wide search for logger.warn, found one and changed (view.py)

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #1307 (489b91c) into main (9c798d3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1307   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files          51       51           
  Lines        2204     2204           
=======================================
  Hits         1952     1952           
  Misses        252      252           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c798d3...489b91c. Read the comment docs.

@kewlguy781 kewlguy781 linked an issue Jul 22, 2021 that may be closed by this pull request
Copy link
Member

@kfoley-18F kfoley-18F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kfoley-18F kfoley-18F merged commit acb4467 into main Jul 22, 2021
@kfoley-18F kfoley-18F deleted the jon branch July 22, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the 'warn' method is deprecated
3 participants