Update Django to 3.2 #1323
Merged
Update Django to 3.2 #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror from 28 to 11 according to test unit
|
Woohooooo!! Thank you @kewlguy781 !!! Requesting some review of the Decimal and AutoField changes from @Jkrzy pretty please. I'm super-excited to get this merged... ❤️ |
Jkrzy
suggested changes
Aug 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #1323 +/- ##
==========================================
+ Coverage 88.61% 88.63% +0.02%
==========================================
Files 51 51
Lines 2222 2226 +4
==========================================
+ Hits 1969 1973 +4
Misses 253 253
Continue to review full report at Codecov.
|
Jkrzy
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will update the Django web application to 3.2 (which is the next LTS release)
Additional information
Changes done to work with Django 3.2:
billable = Coalesce(Sum('timecardobjects__hours_spent', filter=billable_filter), 0)->billable = Coalesce(Sum('timecardobjects__hours_spent', filter=billable_filter), Decimal('0'))The former code set the variable as integer 0, while the rest is in Decimal. We changed it to Decimal to play nice with other variables that are already in Decimal. See Value() Changes under ModelAutoFieldinstead of new defaultBigAutoFieldhowever, we will need to revisit this and migrate into database.cg-django-uaato support Django 3.2 (Special shout out to @bengerman13 for working with me)