Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional help banner from timecard page #1376

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

neilmb
Copy link
Member

@neilmb neilmb commented Oct 13, 2021

Description

The timecard page is getting crowded with informational banners. This removes the "Additional info" banner that links to the Handbook page on tock. Analytics suggests that no one ever clicks on that link.

@colinmurphy01 requested this change .

Screen Shot 2021-10-13 at 1 59 31 PM

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #1376 (3029990) into main (879e68c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          51       51           
  Lines        2280     2280           
=======================================
  Hits         2054     2054           
  Misses        226      226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879e68c...3029990. Read the comment docs.

@colinmurphy01
Copy link
Member

Thank you!

is it normal that the copy in the all of the alert banners isn't full width?
Screen Shot 2021-10-13 at 2 56 34 PM

Copy link
Contributor

@caleywoods caleywoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly deleted 🤌

@neilmb
Copy link
Member Author

neilmb commented Oct 14, 2021

is it normal that the copy in the all of the alert banners isn't full width?

It is. Digging in the Chrome Dev Tools, it looks like the USWDS .usa-content p element has a CSS max-width of 68ex.

@neilmb neilmb merged commit 62756b3 into main Oct 14, 2021
@neilmb neilmb deleted the remove-additional-info branch October 14, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants