Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate against browser phishing #1385

Merged
merged 1 commit into from
Dec 7, 2021
Merged

mitigate against browser phishing #1385

merged 1 commit into from
Dec 7, 2021

Conversation

lauraGgit
Copy link

Description

Include a high-level description of the issue your pull request fixes; include only one issue per pull request. Link to the GitHub issue it resolves.

Additional information

Include any of the following (as necessary):

  • Relevant research and support documents
  • Screenshot images
  • Notes

@codecov-commenter
Copy link

Codecov Report

Merging #1385 (c82c7f3) into main (0413874) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1385   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          51       51           
  Lines        2280     2280           
=======================================
  Hits         2054     2054           
  Misses        226      226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0413874...c82c7f3. Read the comment docs.

@lauraGgit lauraGgit requested a review from neilmb December 6, 2021 19:07
Copy link
Member

@neilmb neilmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that this is the result of grepping for target=_blank, but all of these look good. The Dockerfile and plotly.js changes seem unrelated to the intent of the PR. Do those need to stay?

@lauraGgit
Copy link
Author

@neilmb the plotly changes were also the result of the grep to add the norel attribut. We might consider trying to improve that upstream.

The Dockerfile change was because the dockerfile update was breaking local development since the Pipfile.lock wasn't happy with conflicting python versions and the deployed version I believe is at 3.9.

@kfoley-18F kfoley-18F merged commit f344996 into main Dec 7, 2021
@kfoley-18F kfoley-18F deleted the sec-fixes branch December 7, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants