Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply all current Python package updates #1817

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

nateborr
Copy link

@nateborr nateborr commented Oct 18, 2024

Description

Adjust the project's dependency requirements in the Pipfile and install available updates.

cg-django-uaa needs to be at version 2.1.5 or greater to be compatible with Django 4.x, based on an installation requirement.

cg-django-uaa 2.1.5 is not compatible with Django below version 4.x, so this updates the django requirement accordingly. For good measure I've also constrained it to disallow updating Django to a new major version without deliberately updating the Pipfile.

Testing

Confirm that the automated tests pass. Once it's merged, I'll monitor the cloud.gov environment and confirm that the updated application starts correctly in that environment.

I've smoke-tested this update in a local development environment, including the admin console and API. I'll repeat that in staging, taking advantage of the more robust test data there.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (91a9dfd) to head (7b22d94).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          66       66           
  Lines        4177     4177           
=======================================
  Hits         3934     3934           
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateborr nateborr force-pushed the tock-1796-all-updates branch from e239ca5 to e7196c5 Compare October 18, 2024 17:58
@nateborr nateborr changed the title [DRAFT] apply all current package updates Apply all current package updates Oct 18, 2024
@nateborr nateborr changed the title Apply all current package updates Apply all current Python package updates Oct 18, 2024
@nateborr nateborr marked this pull request as ready for review October 18, 2024 20:58
@cantsin cantsin merged commit 22c893e into main Oct 18, 2024
3 checks passed
@cantsin cantsin deleted the tock-1796-all-updates branch October 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants