Show both 18F and CoE projects on timecard entry page #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cantsin
approved these changes
Nov 7, 2024
neilmb
force-pushed
the
nmb/1002-18f-coe-special
branch
from
e3ebd13 to
e63172f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
+ Coverage 94.18% 94.19% +0.01%
==========================================
Files 66 66
Lines 4177 4188 +11
==========================================
+ Hits 3934 3945 +11
Misses 243 243 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/18F/TLC-crew/issues/1002 asks for a solution for 18F and CoE staff to tock to the same project. As discussed there, the only fix needed is to include the other orgs projects on the timecard entry page. This least-effort solution special-cases that filtering logic for just those two organizations so that they will see each other's projects.
There was a test case for this and I've updated it to reflect the new special-case behavior.