Add support for additional non-billable projects for the snippets report #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset adds a bit of flexibility to the snippets report to include additional project line items instead of just the old General line item. The reason for this is once the General project was retired in favor of the newer non-billable project line items, the report lost its usefulness and would not display any of the new information. If we ever want to add additional projects to this report, it should just be a matter of including the project ID with the newly defined constant.
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 90.94% 90.95% +<.01%
==========================================
Files 38 38
Lines 1701 1702 +1
==========================================
+ Hits 1547 1548 +1
Misses 154 154
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds a bit of flexibility to the snippets report to include additional project line items instead of just the old General line item. The reason for this is once the General project was retired in favor of the newer non-billable project line items, the report lost its usefulness and would not display any of the new information. If we ever want to add additional projects to this report, it should just be a matter of including the project ID with the newly defined constant.