-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminate all UAA sessions at the server level #814
Conversation
In order to deploy this to production, we need to add the |
a46e519
to
97ed1d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, thank you so much for tracking this down and following up on it, @rogeruiz!
@@ -12,7 +12,7 @@ def successful_login(sender, request, user, **kwargs): | |||
|
|||
|
|||
def successful_logout(sender, request, user, **kwargs): | |||
logger.info(f'Successful logout event for {user.username}.') | |||
logger.info(f'Successful logout event for {user}.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to leave this as user.username
, or are you going for the repr
/str
defined on the model instead by doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value that got sent over after the redirect was no longer a Django user but rather the string of the user. This was occurring after the redirect I believe. when I user user.username
it was hitting an error. I figured it's also easier to just rely on the str
defined on the model anyway here. It never felt right to drill down into when the string representation of the User
model could change and be more useful.
Whoops, gotta fix the tests here! 🐠 |
Codecov Report
@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 90.85% 90.82% -0.03%
==========================================
Files 38 38
Lines 1716 1722 +6
==========================================
+ Hits 1559 1564 +5
- Misses 157 158 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks @rogeruiz! Let's verify once more in staging too, once it's in there.
This addresses #810 with the following solution.