Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown safely #833

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Markdown safely #833

merged 4 commits into from
Oct 10, 2018

Conversation

Jkrzy
Copy link
Contributor

@Jkrzy Jkrzy commented Oct 4, 2018

Description

First steps for #819, disabling attributes for rendered markdown and pre-rendering the HTML.

This doesn't address potentially layout breaking markdown, not quite sure how to tackle that at the moment.

@codecov-io
Copy link

Codecov Report

Merging #833 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage    90.9%   90.99%   +0.08%     
==========================================
  Files          39       39              
  Lines        1749     1754       +5     
==========================================
+ Hits         1590     1596       +6     
+ Misses        159      158       -1
Impacted Files Coverage Δ
hours/utils.py 100% <0%> (ø) ⬆️
hours/views.py 87.68% <0%> (+0.06%) ⬆️
hours/models.py 96.7% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d117375...b918314. Read the comment docs.

@tbaxter-18f tbaxter-18f merged commit f3d9dec into master Oct 10, 2018
@Jkrzy Jkrzy deleted the markdown-safely branch October 10, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants