Round Total Hours sum to 2 decimal precision. #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848.
We shouldn’t need anything more than 2 digits of decimal precision to calculate Total Hours. This fixes common floating point precision issues in JavaScript, most easily seen by adding
0.2 + 0.2 + 0.2
(which should result in0.6
, as shown below, but results in0.6000000000000001
without rounding.This is my first time contributing to a python project, so I’m unsure of how to write a test to cover this — let me know how, and I’d be more than happy to add (pun intended) one!