Use default Django handlers for 400, 403, 404, and 500 errors #858
Conversation
| {% extends "base.html" %} | ||
|
|
||
| {% block content %} | ||
| <h2>Bad Request</h2> |
There was a problem hiding this comment.
Let's ping someone from content or writing lab and see if they have any suggestions on more user-friendly copy here.
There was a problem hiding this comment.
@amandacostello can be of assistance. Looping in.
There was a problem hiding this comment.
@amandacostello any update?
There was a problem hiding this comment.
Hi! Still getting my feet under me with GitHub. You're looking for copy related to just 400 error returns, or also 403, 404, and 500?
There was a problem hiding this comment.
In particular, 400, but if there was general guidance for the others we'd be happy to incorporate that as well.
There was a problem hiding this comment.
I've got some writing for each, though what usually triggers the 400 on the client side? Also, as a new GitHub person, how/where should I put the new content? Or just put it in a comment here?
There was a problem hiding this comment.
Error: Bad Request (400)
We can't process your request due to something wrong on your end, like a message being too large or (other common example seen in Tock)
Error: Access forbidden (403)
Your account doesn't have access. Make sure you're logged in, check your VPN connections, and that your account has the correct permissions enabled.
Error: File not found (404)
Looks like the file you're requesting isn't here anymore. Contact (name/email) or try (search)
Error: Internal Server Error (500)
Something's gone wrong on our side. Contact (name/email) to let them know.
| handler400 = 'tock.views.handler400' | ||
| handler403 = 'tock.views.handler403' | ||
| handler404 = 'tock.views.handler404' | ||
| handler500 = 'tock.views.handler500' |
There was a problem hiding this comment.
I love the smell of red backgrounds in a pull request. Smells like... victory.
|
@Jkrzy Do you think we'll be able to get the content updates in for the March 5 release? |
|
Thanks @amandacostello!! We're going to roll the content updates into a new issue and close this one, focused on the back-end implementation. |
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 91.62% 91.66% +0.03%
==========================================
Files 39 39
Lines 1684 1668 -16
==========================================
- Hits 1543 1529 -14
+ Misses 141 139 -2
Continue to review full report at Codecov.
|
Description
For #842, include a
400.htmltemplate and fallback to default Django error handlers.Additional information
Current implementation for these handlers provides no functionality beyond what Django provides by default.
views.defaults.permission_denied for example, renders the
403.htmltemplate with the exception made available in the template context.