Update jquery and django #906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #906 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 39 39
Lines 1668 1668
=======================================
Hits 1529 1529
Misses 139 139Continue to review full report at Codecov.
|
With this commit we move all of our vendored js/css dependencies into a single folder. We're also renaming w/ versions and making the necessary template changes to update paths. This will give us greater visibilty into the current versions being served by tock. As part of this cleanup, remove datatables.js entirely as it is not currently in use.
| var $table = $('#dataTable').dataTable({ | ||
| scrollX: true, | ||
| paging: false, | ||
| lengthChange: false |
There was a problem hiding this comment.
This line contained a syntax error which has prevented datatables from running. It doesn't look like this has worked for quite some time as resolving the syntax breaks styling on the page. Herein we remove in favor of fixing.
There was a problem hiding this comment.
maybe this is an opportunity to remove the datatable dependency altogether?
I'd love it if we could get to a point where we didn't have a jquery dependency, either. This might be one step in that direction?
There was a problem hiding this comment.
We are 😄, that code snippet and the source files associated with datatables are removed w/ this PR.
|
Hey @amymok, just pushed another update here for latest dependencies as well as a general clean-up of our vendor'd things being served out of An additional note on the removal of datatables.js here: dcebc5b#r312072292 |
Description
Per #905, Updating our vendored version of
jquery.min.jsto the latest version. Also updating documentation to reflect our use of NPM alongside vendored dependencies.