Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table of recent Tocks to user details #927

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Add table of recent Tocks to user details #927

merged 1 commit into from
Nov 25, 2019

Conversation

Jkrzy
Copy link

@Jkrzy Jkrzy commented Nov 25, 2019

Description

MVP for #900

For each user details page, we display a table of the 5 most recent reporting periods and hours per project tock'd therein.

Table is rendered on both administrative and standard views of user details page.

Additional information

Example using fake data

Screen Shot 2019-11-25 at 11 37 32 AM

from django.views.generic.edit import FormView
from rest_framework.permissions import IsAuthenticated

from tock.utils import PermissionMixin, IsSuperUserOrSelf
from tock.utils import IsSuperUserOrSelf, PermissionMixin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious -- and unrelated to this PR -- are you using an opinionated linter (black or whatever)? Should we recommend developing with one?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not beyond the established ones, Flake8 and bandit which are in the docs and CI pipeline. This was me running a sort after adding an import.

That said...I'm not sure if Flake8 is scanning for https://www.python.org/dev/peps/pep-0008/#imports at the moment. Will look into it.

@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #927 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #927     +/-   ##
=========================================
- Coverage   91.66%   91.46%   -0.2%     
=========================================
  Files          39       39             
  Lines        1668     1688     +20     
=========================================
+ Hits         1529     1544     +15     
- Misses        139      144      +5
Impacted Files Coverage Δ
employees/views.py 95.89% <0%> (-4.11%) ⬇️
projects/models.py 97.52% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee797c8...49d6d9d. Read the comment docs.

For each user, we display a table of N
recent reporting periods and hours per
project tocked therein.
@tbaxter-18f tbaxter-18f merged commit 7caad03 into master Nov 25, 2019
@tbaxter-18f tbaxter-18f deleted the emp-recent branch November 25, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants