Clarify timecard validation errors #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 39 39
Lines 1688 1688
=======================================
Hits 1544 1544
Misses 144 144
Continue to review full report at Codecov.
|
tbaxter-18f
reviewed
Nov 25, 2019
tbaxter-18f
reviewed
Nov 25, 2019
tbaxter-18f
reviewed
Nov 25, 2019
Provide project name when an error is reported for a timecard entry. Also, link directly from the error to the referenced project. Remove duplicated id values in rendered forms. Remove repeated display of errors/messages at bottom of form.
|
Very lightly reworked a bit of the javascript to remove the ID attr's which were being duplicated in the template |
tbaxter-18f
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working towards resolution of #885, we're making incremental improvements to the error messaging on timecard submission.
Specifically:
Additional information