Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TimeCardObject.submitted #933

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Remove TimeCardObject.submitted #933

merged 3 commits into from
Dec 11, 2019

Conversation

Jkrzy
Copy link
Contributor

@Jkrzy Jkrzy commented Dec 4, 2019

Description

Resolves: #881 by removing TimeCardObject.submitted and replacing references in queries/tests to the associated TimeCard object's submitted field.

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #933 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   91.47%   91.45%   -0.03%     
==========================================
  Files          39       39              
  Lines        1689     1685       -4     
==========================================
- Hits         1545     1541       -4     
  Misses        144      144
Impacted Files Coverage Δ
hours/views.py 88.2% <0%> (-0.07%) ⬇️
hours/models.py 96.21% <0%> (-0.05%) ⬇️
hours/admin.py 71.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115d634...d149f10. Read the comment docs.

Copy link
Member

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried: toggling submitted status on timecard using admin, submitted timecard as user, unsubmitted that timecard, ran reports with and without submitted timecard, and tested the API likewise. All LGTM with the caveat that I'm still new to this codebase.

requirements.txt Outdated Show resolved Hide resolved
tock/projects/tests.py Show resolved Hide resolved
Refactoring to remove `submitted` from the
`TimeCardObject` class.

Queries for non-submitted `TimeCardObject`s
now directly evaluate the value of the associated
`TimeCard`
@Jkrzy Jkrzy merged commit 2c21941 into master Dec 11, 2019
@Jkrzy Jkrzy deleted the remove-submitted branch February 4, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce project line submission at timecard submission
3 participants