Tweak CircleCI configuration for builds. #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now has a default value, so it is no longer required.
Use npm ci over npm install — which will not edit any dependencies in the lockfile and instead fail if anything is unavailable. Additionally, updates the cache name to use this lockfile, and caches npm’s cache folder (as npm ci destroys node_modules always on run).
Probably faster, less arbitrary!
The `nc` arguments are different between OS X and Linux… ugh.
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 39 39
Lines 1685 1685
=======================================
Hits 1541 1541
Misses 144 144
Continue to review full report at Codecov.
|
Jkrzy
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #943.
CircleCI tweaks to simplify, modernize, and improve usage of CircleCI:
working_directoryconfiguration, as it is no longer required.npm ciovernpm install.This PR does not address deployment issues, will follow-up with an additional PR around deploys.