Use cf-rolling-restart over cf-recycle-plugin.

[adunkman]

Related to #943.

Rolling-restart is more recently maintained, is the original fork, and works with the latest CF CLI for when we upgrade.

It’s a bit of a shot-in-the-dark here since I don’t 100% understand what’s going on — the cf-recycle-plugin plugin isn’t correctly detecting process restarts. I had thought this was due to conflicting recycle jobs — one job was recycling a process out from the other — but since removing the concurrent jobs, the issue is not fixed.

Looking at this morning’s run, the CircleCI job output seems to indicate that Instance 0 was never restarted, which caused the job to timeout. However, looking at the cell restart logs, we can see that it was correctly restarted:

Timestamp	Message
05:09:33.047	Cell 7e7732c4-f516-4420-a8b9-fb94ccea7405 stopping instance f3c7fa65-22e8-4792-7f95-4141
05:09:49.396	Cell 7e7732c4-f516-4420-a8b9-fb94ccea7405 destroying container for instance f3c7fa65-22e8-4792-7f95-4141
05:09:52.034	Cell 7e7732c4-f516-4420-a8b9-fb94ccea7405 successfully destroyed container for instance f3c7fa65-22e8-4792-7f95-4141
05:10:15.651	Cell 7e7732c4-f516-4420-a8b9-fb94ccea7405 creating container for instance 1c8832a7-4445-4c50-55e7-409e
05:10:16.530	Cell 7e7732c4-f516-4420-a8b9-fb94ccea7405 successfully created container for instance 1c8832a7-4445-4c50-55e7-409e
05:10:16.913	Downloading droplet...
05:10:22.451	Downloaded droplet (69.8M)
05:10:22.451	Starting health monitoring of container
05:10:31.906	Container became healthy

This leads me to believe that this is an issue with the plugin — hence the PR. I’m pretty comfortable just trying something newer and seeing if it works, and moving on with our lives if it does. 🤷‍♂

[adunkman]

Oh, forgot to mention — I tested the changes by spinning up 18fgsa/cloud-foundry-cli on my machine and issuing these commands against a sandbox cloud.gov application, which completed successfully.

[codecov-io]

Codecov Report

Merging #954 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files          39       39           
  Lines        1685     1685           
=======================================
  Hits         1541     1541           
  Misses        144      144

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742b690...08f5f64. Read the comment docs.

[cryptofilegsa]

cleaner - removes unnecessary use of curl. looks good to me.