Moved utilization reports #966
Conversation
Codecov Report
@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 91.45% 91.52% +0.07%
==========================================
Files 39 39
Lines 1685 1699 +14
==========================================
+ Hits 1541 1555 +14
Misses 144 144
Continue to review full report at Codecov.
|
|
@tbaxter-18f Can you update the PR description above: #966 (comment) |
tock/tock/templates/_navigation.html
Outdated
| <span>Reports</span> | ||
| </a> | ||
| </li> | ||
| {% if user.is_staff %} |
There was a problem hiding this comment.
This should be request.user.is_staff
There was a problem hiding this comment.
Huh. I thought we passed user into context, but it appears you're right!
| </a> | ||
| </li> | ||
| {% if user.is_staff %} | ||
| <li> |
There was a problem hiding this comment.
This doesn't render for me. No menu actually shows up.
There was a problem hiding this comment.
We may need to be sure you're set up as superuser and staff in the admin.
tock/tock/templates/_navigation.html
Outdated
| {% if request.user.is_staff %} | ||
| <li> | ||
| <button class=" | ||
| usa-accordion-button usa-nav-link" aria-expanded="false" aria-controls="side-nav-2"> |
There was a problem hiding this comment.
The side-nav-2 is conflicting with the one under Administrative, this is causing the submenu not rendering. So choose something else here.
tock/tock/templates/_navigation.html
Outdated
| usa-accordion-button usa-nav-link" aria-expanded="false" aria-controls="side-nav-2"> | ||
| <span>Reports</span> | ||
| </button> | ||
| <ul id="side-nav-2" class="usa-nav-submenu" aria-hidden="true"> |
There was a problem hiding this comment.
Same comment as above for the side-nav-2. Choose another id.
There was a problem hiding this comment.
Good catch, Amy. Those are also bad IDs, so I've made them a bit more descriptive.
There was a problem hiding this comment.
@tbaxter-18f Did you push the commit?
amymok
dismissed
Jkrzy’s stale review
The request has been completed, description has been added
|
There's no changes in dependency, Snyk is being funky here for pending. Will bypass and merge. |
Moves utilization reports from behind a menu only superusers can see and into a location where they can be viewed by anyone. Transparency!