Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type hint #17

Merged
merged 5 commits into from
May 27, 2024
Merged

Correct type hint #17

merged 5 commits into from
May 27, 2024

Conversation

juliangums
Copy link
Contributor

No description provided.

@juliangums juliangums mentioned this pull request May 27, 2024
@jackwh
Copy link

jackwh commented May 27, 2024

Hey @juliangums, just tested and I can see each line causes a syntax error:

protected Arrayable|Closure|string $descriptions = [];

Cannot use array as default value for property JaOcero\RadioDeck\Forms\Components\RadioDeck::$descriptions of type Illuminate\Contracts\Support\Arrayable|Closure|string

You should extend the union type back to how it was originally, by adding |array:

protected Arrayable|Closure|string|array $descriptions = [];

@juliangums
Copy link
Contributor Author

@jackwh can you check again?

@199ocero 199ocero merged commit 1341a73 into 199ocero:main May 27, 2024
@199ocero
Copy link
Owner

Merge @juliangums @jackwh yeah sorry I didn't check the last PR I thought it only removes the facade but some data type are remove. Can you check it again @jackwh ?

@juliangums juliangums deleted the patch-2 branch May 28, 2024 14:41
@juliangums
Copy link
Contributor Author

juliangums commented May 28, 2024

My bad for not double-checking. I was experimenting with other parts of the code, and this should not have made it in the code. Was committed by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants