Settings: Garden permissions #860
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kamikazebr
reviewed
May 13, 2022
| @@ -0,0 +1,118 @@ | |||
| /* eslint-disable react/jsx-key */ | |||
There was a problem hiding this comment.
Maybe the problem with names don't show up could be related to it. Same if it's not, I'll recommend remove it and set proper keys attributes to react render properly
There was a problem hiding this comment.
I don't think we really need this line also.
tmoutinho
approved these changes
May 13, 2022
| import Permissions from './Permissions' | ||
|
|
||
|
|
||
| const LayoutWrapper = styled(Layout)` |
| @@ -0,0 +1,118 @@ | |||
| /* eslint-disable react/jsx-key */ | |||
There was a problem hiding this comment.
I don't think we really need this line also.
kamikazebr
reviewed
May 13, 2022
| @@ -65,17 +90,18 @@ function GlobalPreferences({ compact, onClose, onNavigation, sectionIndex }) { | |||
| getEvmCrispr() | |||
| }, [account, connectedGarden, ethers, isSafari]) | |||
|
|
|||
| console.log('sectionIndex ', sectionIndex) | |||
There was a problem hiding this comment.
Maybe remove the console log here
kamikazebr
reviewed
May 13, 2022
| appAddress: string, | ||
| appName: string, | ||
| appIcon: string, | ||
| description: string | undefined, // TODO- check why this is happening proabably old ABI |
There was a problem hiding this comment.
You are still getting undefined here some times?
kamikazebr
reviewed
May 13, 2022
| } | ||
|
|
||
| const rolesWithEntitiesResolved: Array<RoleProps> = appsWithRolesResolved ? appsWithRolesResolved.map((app: any) => { | ||
| return app.roles.map((role: any) => { |
There was a problem hiding this comment.
It's possible we get the correct type here in instead any, it could help track changes in the code below
reznord
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still didn't added the filters since is going to take me some time given the way the connect returns the data for the roles but i can add later in another pr since i want to move to work on the conviction voting v2.
There is one case where the permission has no name for some reason, needs further investigation.